chore: move dev-only dependencies to devDependencies#117
Open
sodabrew wants to merge 1 commit intosendgrid:mainfrom
Open
chore: move dev-only dependencies to devDependencies#117sodabrew wants to merge 1 commit intosendgrid:mainfrom
sodabrew wants to merge 1 commit intosendgrid:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.
Accepted.
Fixes
This package does not have a runtime dependency on chai or esdocs. These are devDependencies. The two negative effects of having these listed as runtime dependencies are larger bundle / node_modules size at runtime and that downstream applications get flagged by Dependabot and other tools for having vulnerable and outdated dependencies.
See PR #53 for the original addition of these deps.
Checklist
If you have questions, please file a support ticket.